feat: Implement custom stickiness #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sighphyre
commented
Dec 1, 2021
sighphyre
commented
- Add custom stickiness for feature variants
- Add custom stickiness for flexible rollout strategies
- Implement custom stickiness property on variant defs
- Force context to resolve to nil instead of crashing with empty props
|
@sighphyre looks like integration tests for variants is currently failing also, it needs to be updated to latest version, with custom stickiness examples: |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 1574701104
💛 - Coveralls |
rarruda
reviewed
Dec 2, 2021
rarruda
reviewed
Dec 2, 2021
sighphyre
force-pushed
the
feature/implement_custom_stickiness
branch
from
ecb222d to
1d97b20
Compare
rarruda
requested changes
Dec 5, 2021
There was a problem hiding this comment.
This is great! But I do have a couple of concerns that I would like to see addressed before merging:
- change the code for resolving stickiness to something more ruby idiomatic
- not changing the signature (results) for
get_by_name()in this PR. - rebase this branch to master, and run
bundle exec rubocopto catch any code style deviations from the project standard.
sighphyre
force-pushed
the
feature/implement_custom_stickiness
branch
from
040d7da to
540b143
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Add custom stickiness for feature variants - Add custom stickiness for flexible rollout strategies - Implement custom stickiness property on variant defs - Force context to resolve to nil instead of crashing with empty props
- Upgrade CI to use latest client spec - Fix an issued where custom properties would resolve incorrectly if camel cased in context - Fix an issue where stickiness could be nil instead of 'default'
Improve readability of stickiness resolution Co-authored-by: Renato Arruda <[email protected]>
sighphyre
force-pushed
the
feature/implement_custom_stickiness
branch
from
4a7e739 to
3abfee7
Compare
rarruda
reviewed
Dec 10, 2021
rarruda
approved these changes
Dec 13, 2021
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.